view test/runtests @ 434:052c5f335a92

Fix bug in like terms collection in expression simplification Like term collection would lose the actual "variable" part of the term if the second term collected happened to have no coefficient. This would cause the expression to take the value of the calculated coefficient which is obviously wrong. Thanks to hider <stego@satx.rr.com> for reporting the bug and providing a proper test case. Observation: this bug has been present since the first pre-release of lwtools 3.0 when the algebraic expression system was introduced. Apparently people tend not to create expressions that trigger the like terms handler. The specific conditions require the symbol to be undefined and the second operand to the addition has to have no coefficient so it's likely a fairly rare scenario. Still, it is somewhat surprising that nobody tripped on it before now.
author William Astle <lost@l-w.ca>
date Mon, 23 Jan 2017 22:58:36 -0700
parents 3413a88f4d09
children 3cd8aa013b88
line wrap: on
line source

#!/usr/bin/perl
#
# This program will execute all programs in the "tests" directory. Each
# program is expected to produce output as follows on stdout:
#
# each line begins with a test name followed by whitespace followed by
# PASS, FAIL, or SKIP.
#
# stderr is not redirected during testing. Any test that might spam stderr
# is encouraged to redirect it somewhere useful.
#
# After each test script exits, a report indicating number passed, failed,
# and skipped is presented, or if the script failed to run.
#
# Once all tests have been run, a report showing the grand total number of
# tests performed, passed, failed, and skipped.
#
# Each test can be in any programming language that is appropriate for
# the task.
#
# Each test can assume the current directory is the root of the source tree.

use File::Basename;

$testdir = dirname($0) . '/tests';

opendir DH, $testdir;
while ($fe = readdir DH)
{
	next if ($fe =~ /^\./);
	next if ($fe =~ /~$/);
	
	$fn = $testdir . '/' . $fe;

	open P,"$fn|";
	while (<P>)
	{
		chomp;
		($tn, $ts) = split /\s+/;
		$testresults{$fe}{$tn} = $ts;
		if ($ts eq 'PASS')
		{
			$testspassed += 1;
			$testresults{$fe}{'..passed'} += 1;
		}
		elsif ($ts eq 'FAIL')
		{
			$testsfailed += 1;
			$testresults{$fe}{'..failed'} =+ 1;
		}
		elsif ($ts eq 'SKIP')
		{
			$testsskipped += 1;
			$testresults{$fe}{'..skipped'} += 1;
		}
		else
		{
			$testsunknown += 1;
			$testresults{$fe}{'..unknown'} += 1;
		}
		$teststotal += 1;
		$testresults{$fe}{'..total'} += 1;
	}
	close P;
	$fdn = $fe;
	$fdn =~ s/\..+?$//;
	$rline = sprintf("%-25.25s: %d/%d (%d skipped, %d unknown, %d failed)",  $fdn, $testresults{$fe}{'..passed'}, $testresults{$fe}{'..total'}, $testresults{$fe}{'..skipped'}, $testresults{$fe}{'..unknown'}, $testresults{$fe}{'..failed'});
	print "$rline\n";
}
closedir DH;

print sprintf("\n===================\nTotal: %d/%d (%d skipped, %d unknown, %d failed)\n", $testspassed, $teststotal, $testsskipped, $testsunknown, $testsfailed);

if ($testspassed < $teststotal)
{
	print "\nThe following tests either failed or were otherwise dubious:\n";
	foreach $i (keys %testresults)
	{
		$fdn = $i;
		$fdn =~ s/\..+?$//;
		foreach $j (keys %{ $testresults{$i} })
		{
			next if $j =~ /^\./;
			if ($testresults{$i}{$j} ne 'PASS')
			{
				print "$fdn/$j: $testresults{$i}{$j}\n";
			}
		}
	}
	exit 1;
}
exit 0;